Allon Prooit
11 months ago
A small component to keep the topbar in focus. Also includes javascript that is supposed to make the topbar scroll up when scrolling down and then return after scrolling back up.
Needing help to further develop it.
V1.0 - Initial release. Keeps the topbar constantly in focus.
V1.1 - Code corrected for the community to help develop it.
V1.1.1 - Code corrected by Rafael Amorim. Code needs to be adjusted for right side buttons in CSS.
Michael Zülsdorff
Replied 11 months ago
Just tried V1.1
and I give up trying to help at this point because you seem not really willing to take advice.
Two days ago I wrote "Now, that this file IS already recognized as Javascript, any additional <script></script> tags inside are not allowed / confusing the script interpreter.
Not a line of yours you don't understand this sentence, you don't agree ... whatever. You just silently leave the </script> tag in place. I'm sorry, but my idea of cooperation is different.
Allon Prooit
Replied 11 months ago
Not sure what the issue is Z Man. I went ahead and posted my best attempt at making it work. Still throws an error. Guessing I need a function to give the "topbar" an ID. Any thoughts?
Michael Zülsdorff
Replied 11 months ago
Ok,
so with document.getElementById(".topbar")
w3schools is trying to find and access a node with the id .topbar
And the result is:
Uncaught TypeError: Cannot read properties of null (reading 'style')
null means: not found.
Thus, I'd ask myself: Does a node with an id like that exist at all in my theme? ;)
Allon Prooit
Replied 11 months ago
Just so you know, the basic coding for the component came from here...
w3schools.com
Allon Prooit
Replied 11 months ago
Here's the error again, hopefully easier to read...
Also, thanks Rafael! Glad to find some good code to work with. The Github repository has the V1.0 uploaded. AT3META's GitHub
Rafael [redcrested.net]
Replied 11 months ago
I'm flattered to see my component been using as inspiration to a new component :-)
If you can, put your code into GitHub to allow us improve it.
Michael Zülsdorff
Replied 11 months ago
Sorry, but I'm unable to read that. Upload that new code and we'll see ..
Allon Prooit
Replied 11 months ago
Ok, so I made a number of adjustments and ended up with the following error. Not sure how to proceed. See image for details... something about the javasript.
Michael Zülsdorff
Replied 11 months ago
The options to choose from are
ossn_extend_view('ossn/site/head', 'js/topbarfocusizer');
in order to get your script separated and uncached in the head area of the html
ossn_extend_view('js/ossn.site', 'js/topbarfocusizer');
in order to get your script merged with other component's javascript and being minified and cached (with Ossn cache=enabled)
Allon Prooit
Replied 11 months ago
Indeed, that is the difference. Any thoughts on what I should change to get this component working to spec? I see a few alterations i can make...
