Quesion about OssnUser method getFriendRequests

Jason Lester Posted in Beginning Developers 1 year ago

While surfing the code in classes/OssnUser.php I noticed that the method getFriendsRequest seems to make a loop of seemingly redundant queries between lines 401 and 415.
Wouldn't the original fetch on line 400 have the same results?

Replies
Indonesian Arsalan Shah Replied 1 year ago

The second query checks if they are not friends. However the method need improvement it has not been touched since OSSN 1.x

https://github.com/opensource-socialnetwork/opensource-socialnetwork/issues/2217

us Jason Lester Replied 1 year ago

It was right in front of me, question answered.